Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COST-973: Sources hardening #2637

Merged
merged 35 commits into from
Feb 8, 2021
Merged

COST-973: Sources hardening #2637

merged 35 commits into from
Feb 8, 2021

Conversation

dccurtis
Copy link
Contributor

@dccurtis dccurtis commented Feb 8, 2021

General stability work to minimize on redundant processing.

Extensive CRUD testing has been done in the QA OCP environment.

  • CRUD with all source types, editing each field, verifying source status is correct
  • Added duplicate accounts, verified source status. Fixed duplicate accounts by editing
  • Ran QE Sources crud automation
  • Test PATCH flow and verified it could seamlessly transition to new app-extra flow
    195 passed, 9 skipped, 3064 deselected, 3 warnings in 541.91s (0:09:01)

@dccurtis dccurtis requested a review from a team February 8, 2021 14:27
@dccurtis dccurtis self-assigned this Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #2637 (a18b927) into master (785199c) will decrease coverage by 0.0%.
The diff coverage is 90.8%.

@@           Coverage Diff            @@
##           master   #2637     +/-   ##
========================================
- Coverage    94.7%   94.7%   -0.0%     
========================================
  Files         282     282             
  Lines       21527   21574     +47     
  Branches     2444    2455     +11     
========================================
+ Hits        20396   20438     +42     
- Misses        679     683      +4     
- Partials      452     453      +1     

lcouzens
lcouzens previously approved these changes Feb 8, 2021
Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dccurtis dccurtis marked this pull request as ready for review February 8, 2021 20:37
lcouzens
lcouzens previously approved these changes Feb 8, 2021
Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor typo but who cares right?

Copy link
Contributor

@lcouzens lcouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You da man!!!

@dccurtis dccurtis merged commit de67c92 into master Feb 8, 2021
@dccurtis dccurtis deleted the sources_dup_status_fix branch February 8, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants