Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest workflow fix #2250

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Unittest workflow fix #2250

merged 7 commits into from
Jul 8, 2020

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jul 8, 2020

For whatever reason, a workflow was using python2 to run the python3.6 unit tests: https://github.com/project-koku/koku/runs/850175190?check_suite_focus=true 🤨

This PR:

  • specifies to install pipenv using python3
  • specifies the branch in the cache key <- this ensures that the dependencies are installed when the branch is first pushed to github

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #2250 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2250     +/-   ##
========================================
+ Coverage    94.4%   94.5%   +0.1%     
========================================
  Files         232     232             
  Lines       16264   16442    +178     
  Branches     1826    1826             
========================================
+ Hits        15355   15533    +178     
+ Misses        581     580      -1     
- Partials      328     329      +1     

@maskarb maskarb self-assigned this Jul 8, 2020
@maskarb maskarb merged commit 422de7c into master Jul 8, 2020
@maskarb maskarb deleted the unittest-workflow branch July 8, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants