Update pronouns to gender neutral variants #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing exception messages and a comment from male pronouns to gender neutral pronouns.
obones
reviewed
Jan 3, 2025
jcl/source/common/JclSysUtils.pas
Outdated
| @@ -4528,7 +4528,7 @@ finalization | |||
| {$ENDIF UNITVERSIONING} | |||
| {$IFDEF MSWINDOWS} | |||
| {$IFDEF THREADSAFE} | |||
| // The user must release shared memory blocks himself. We don't clean up his | |||
| // The user must release shared memory blocks himself. We don't clean up their | |||
There was a problem hiding this comment.
I'm not a native speaker but it feels weird having "himself" followed by "their".
|
Oh, I missed that. Thanks. I'll update it.
…On Fri, Jan 3, 2025 at 3:16 AM obones ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In jcl/source/common/JclSysUtils.pas
<#149 (comment)>:
> @@ -4528,7 +4528,7 @@ finalization
{$ENDIF UNITVERSIONING}
{$IFDEF MSWINDOWS}
{$IFDEF THREADSAFE}
- // The user must release shared memory blocks himself. We don't clean up his
+ // The user must release shared memory blocks himself. We don't clean up their
I'm not a native speaker but it feels weird having "himself" followed by
"their".
—
Reply to this email directly, view it on GitHub
<#149 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGEUVVEM7GENQ4SCTRXQJ7D2IZBO5AVCNFSM6AAAAABQ2LKMGOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRYGY4TIMRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Change himself to themself
obones
requested changes
Jan 31, 2025
| FMultiplier := '�'; | ||
| FMultiplier := '×'; |
There was a problem hiding this comment.
This should not have been changed, the encoding of JCL files must never be UTF-8 as it is not understood by early versions of Delphi/BCB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change exception messages and a comment from male pronouns to gender neutral pronouns.