-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete the datasets import UI code. #18
Conversation
@killfill, just reminder that, this is not tested yet. I will do it in somday, and update the pull request. Currently all the UI and framework code should be done (only tested with fake uploader.) |
quote @killfill from IRC, pay attention :)
|
More info here: https://jira.project-fifo.net/browse/FIFO-387 |
Now this should work. Have tested on DogeOS 0.4.5 :), imported joyent smartmachine datasets without problem. This requires HTML5 FileReader support. But fortunately, recently firefox and chrome all support it. Known issue is that if the inspector is turned on, you probably will see that chrome is dead :), just close the inspector, it should work. the reason should be that huge data is actually loaded into mem and then upload, inspector just goes crazy with that data. Above issue also occurs when you have a xGB dataset.gz. |
Added the file size checking part, will not allow user to upload sth > 250MB, and will warn him to do it with client API, such as PyFi. This is should be a solution usable. |
Hi mate! Its not that i really have try hard to understand this.. (shame on me!) How are you testing this? Thanks!! |
I have added some comments for easier understanding :) It is my issue that write code like sth crazy :) The test data example is also embedded in comments, or you can just download with wget -c https://images.joyent.com/images/19daa264-c4c4-11e3-bec3-c30e2c0d4ec0 -O CentOS-2.6.1.dsmanifest
wget -c https://images.joyent.com/images/19daa264-c4c4-11e3-bec3-c30e2c0d4ec0/file -O CentOS-2.6.1.gz all joyent's datasets |
Hm.. i tried it with the nginx dataset wich is a little smaller, 150MB. |
Where can I get these datasets? I will take more tests.
|
Tried locally, yes, my browser also breaks :( I will find ways to solve this. Wait for my next update. |
I have revised the solution to use XMLHtttpRequest Level 2 API for uploading, this works much better than angular-file-upload one. http://snag.gy/a3csz.jpg This is much robust. And I even suspect that can be used to upload huge files. (I have not remove the 250MB checking currently.) |
No description provided.