fix: Openssl bug fix #908
Open
fix: Openssl bug fix #908
+120
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
requested review from
jeremyrickard and
sozercan
as code owners
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
==========================================
+ Coverage 46.94% 48.18% +1.23%
==========================================
Files 18 18
Lines 2211 2258 +47
==========================================
+ Hits 1038 1088 +50
+ Misses 1115 1112 -3
Partials 58 58 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
openssl-bug-fix
branch
from
3e5a502 to
e2d239d
Compare
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
Signed-off-by: ashnamehrotra <[email protected]>
ashnamehrotra
force-pushed
the
openssl-bug-fix
branch
from
f0aafed to
1ae2797
Compare
sozercan
reviewed
Feb 7, 2025
pkg/pkgmgr/rpm.go
Outdated
| mkdir /tmp/rootfs/var/lib/rpmmanifest | ||
|
|
||
| rpm --dbpath=/tmp/rootfs/var/lib/rpm -qa | tee /tmp/rootfs/var/lib/rpmmanifest/container-manifest-1 | ||
| rpm --dbpath=/tmp/rootfs/var/lib/rpm -qa --qf '%{NAME}\t%{VERSION}-%{RELEASE}\t%{INSTALLTIME}\t%{BUILDTIME}\t%{VENDOR}\t%{EPOCH}\t%{SIZE}\t%{ARCH}\t%{EPOCHNUM}\t%{SOURCERPM}\n' | grep -v '^gpg-pubkey' | tee /tmp/rootfs/var/lib/rpmmanifest/container-manifest-2 |
There was a problem hiding this comment.
we can do rpm --dbpath=/tmp/rootfs/var/lib/rpm --erase --allmatches gpg-pubkey-* instead of ignoring
sozercan
reviewed
Feb 7, 2025
| rm /tmp/rootfs/var/lib/rpm | ||
| rm -rf /tmp/rootfs/var/cache/tdnf | ||
|
|
||
| rpm --dbpath /tmp/rpmdb -qa ` + fmt.Sprintf(queryFormat, resultQueryFormat, pkgs, "/tmp/rootfs/manifest") + `` |
sozercan
reviewed
Feb 7, 2025
| rm -rf /tmp/rootfs/var/cache/tdnf | ||
|
|
||
| rpm --dbpath /tmp/rpmdb -qa ` + fmt.Sprintf(queryFormat, resultQueryFormat, pkgs, "/tmp/rootfs/manifest") + `` | ||
|
|
There was a problem hiding this comment.
looks like this is going to fail validation because we are generating the manifest here, so the expected packages won't match
Signed-off-by: Sertac Ozercan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #809
Closes #850