-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed create-cert init containers #509
Merged
openshift-merge-bot
merged 5 commits into
project-codeflare:main
from
Bobbins228:remove-init
Apr 19, 2024
Merged
Removed create-cert init containers #509
openshift-merge-bot
merged 5 commits into
project-codeflare:main
from
Bobbins228:remove-init
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bobbins228
force-pushed
the
remove-init
branch
2 times, most recently
from
April 12, 2024 15:32
43d8602
to
eb0da8f
Compare
4 tasks
Bobbins228
force-pushed
the
remove-init
branch
3 times, most recently
from
April 17, 2024 14:29
5add116
to
cb14ee4
Compare
/lgtm |
ChristianZaccaria
previously requested changes
Apr 18, 2024
KPostOffice
reviewed
Apr 18, 2024
4 tasks
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Apr 19, 2024
/lgtm |
openshift-merge-bot
bot
merged commit Apr 19, 2024
24a0b6e
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
RHOAIENG-5086
What changes have been made
Removed
create-cert
init containers and related volumes + environment variables.Remove local_interactive`
Verification steps
Setup
Notebook server ODH/RHOAI/Local
git clone https://github.com/project-codeflare/codeflare-sdk.git
poetry build
- install if needed (pip install poetry
)pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl
Testing
ClusterConfiguration
/cluster.up()
creat-cert
init containers,RAY_TLS
related env variables,ca-vol
volumes or the Oauth side car containerChecks