Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed create-cert init containers #509

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Apr 12, 2024

Issue link

RHOAIENG-5086

What changes have been made

Removed create-cert init containers and related volumes + environment variables.
Remove local_interactive`

Verification steps

Setup

Notebook server ODH/RHOAI/Local

  • Clone this repository with git clone https://github.com/project-codeflare/codeflare-sdk.git
  • Checkout this PR's branch
  • Run poetry build - install if needed (pip install poetry)
  • Run pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl
  • Restart your notebook kernel

Testing

  • Create a Ray Cluster with ClusterConfiguration/cluster.up()
  • Inspect that the yaml file does not include the creat-cert init containers, RAY_TLS related env variables, ca-vol volumes or the Oauth side car container

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Bobbins228 Bobbins228 force-pushed the remove-init branch 2 times, most recently from 43d8602 to eb0da8f Compare April 12, 2024 15:32
@Bobbins228 Bobbins228 force-pushed the remove-init branch 3 times, most recently from 5add116 to cb14ee4 Compare April 17, 2024 14:29
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
src/codeflare_sdk.egg-info/PKG-INFO Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/codeflare_sdk/utils/generate_yaml.py Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@astefanutti
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 24a0b6e into project-codeflare:main Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants