Enable Multiple Endpoints and Device Types in Device Composition Insertion #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulr34
changed the title
aronrosenberg
approved these changes
Nov 21, 2024
dhchandw
approved these changes
Nov 21, 2024
tecimovic
approved these changes
Nov 22, 2024
src-electron/db/query-loader.js
Outdated
| // Ensure that deviceType and its necessary properties are defined | ||
| if ( | ||
| !deviceType || | ||
| !deviceType.composition || |
There was a problem hiding this comment.
Couldn't you use the ?. operator here?
Like !(devicetype?.composition?.endpoint) ?
src-electron/db/query-loader.js
Outdated
| // Create insert queries for each deviceType in this endpoint and add them to the insertQueries array | ||
| for (let j = 0; j < deviceTypes.length; j++) { | ||
| const device = deviceTypes[j] | ||
|
|
There was a problem hiding this comment.
Why not:
for ( let device of deviceTypes) {
...
}
I don't think you're using the actual index anywhere, and while there is something cozy about the good old fashioned 1960's C-like for loop, it is visually more taxing than modern JS.
|
Obviously I'm assuming that you tested this well with both Matter and Zigbee, and that you promise you will write unit tests for it! |
paulr34
force-pushed
the
multipleEndpointsComposition
branch
from
1da59a6 to
f71d922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Title: Enable Multiple Endpoints and Device Types in Device Composition Insertion
Description:
This update enhances the insertDeviceComposition function to support multiple endpoints and multiple device types (deviceType) per endpoint. Previously, the code could only insert data for a single endpoint and device type.
Key Changes:
Multiple Endpoints: The function now processes all endpoints in deviceType.composition.endpoint, inserting data for each.
Multiple Device Types per Endpoint: Supports inserting multiple deviceType values per endpoint.
Dynamic Conformance and Constraint: Uses endpoint-specific conformance and constraint values when available, with fallbacks to default deviceType values.
Improved Error Handling: Ensures required data is present and correctly formatted, preventing errors.
Benefits:
Scalability: Handles more complex device compositions with multiple endpoints and device types.
Flexibility: Supports a wider range of device configurations.
Data Integrity: Ensures correct insertion of data for each endpoint and device type.
This update improves flexibility and scalability for device composition handling.