New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Parsing "name" inside Attribute Tag #1470

Merged

ethanzhouyc merged 1 commit into project-chip:master from ethanzhouyc:attribute-name

Oct 24, 2024

Collaborator

ethanzhouyc commented Oct 24, 2024

Support parsing attribute name with new format: <attribute name="attributeName">
Will not affect current parsing format including <attribute>attributeName</attribute> and <description> attributeName</description>
Required by #36223 as CHIP XMLs are moving to the new format


          support parsing name inside attribute tag

b2ca317

ethanzhouyc requested review from paulr34, tecimovic and brdandu as code owners

October 24, 2024 18:23

paulr34 approved these changes

View reviewed changes

ethanzhouyc requested a review from dhchandw

October 24, 2024 19:11

dhchandw approved these changes

View reviewed changes

ethanzhouyc merged commit 57ffa8e into project-chip:master

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dhchandw dhchandw approved these changes

paulr34 paulr34 approved these changes

tecimovic Awaiting requested review from tecimovic tecimovic is a code owner

brdandu Awaiting requested review from brdandu brdandu is a code owner

Labels

None yet