Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Quality tag in Commands #1467

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

dhchandw
Copy link
Collaborator

  • Added support for qualities in commands
  • Added isLargeMessage quality
  • Modified relevant queries and template helpers
  • Also fixed issues with loading of attribute qualities
  • Added tests for both command and attribute qualities

* Added support for qualities in commands
* Added isLargeMessage quality
* Modified relevant queries and template helpers
* Also fixed issues with loading of attribute qualities
* Added tests for both command and attribute qualities
@dhchandw dhchandw force-pushed the task/commandQuality branch from c66b03d to d2e28b6 Compare October 22, 2024 18:50
@dhchandw dhchandw linked an issue Oct 22, 2024 that may be closed by this pull request
src-electron/db/db-mapping.js Show resolved Hide resolved
src-electron/db/db-mapping.js Show resolved Hide resolved
src-electron/db/db-mapping.js Outdated Show resolved Hide resolved
src-electron/db/query-command.js Show resolved Hide resolved
src-electron/db/zap-schema.sql Show resolved Hide resolved
@dhchandw dhchandw requested a review from brdandu October 23, 2024 21:25
@dhchandw dhchandw merged commit fbb31a9 into project-chip:master Oct 24, 2024
14 checks passed
@dhchandw dhchandw deleted the task/commandQuality branch October 30, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ZAP Support for Commands having the 'LargeMessage' quality
3 participants