feat: add mpc theme, refact: variables.scss #1344
Conversation
tbrkollar
force-pushed
the
feature/multiprotocolTheme
branch
from
7880aef to
684dfe1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 66.00% 66.00% -0.01%
==========================================
Files 194 194
Lines 20528 20589 +61
Branches 4455 4472 +17
==========================================
+ Hits 13550 13590 +40
- Misses 6978 6999 +21 ☔ View full report in Codecov by Sentry. |
| // Picking the first category in the case of multi-protocol(zigbee/matter) | ||
| if (Array.isArray(zclProps) && zclProps.length > 0) { | ||
| return zclProps[0].category | ||
| } else { |
There was a problem hiding this comment.
Isn't if (Array.isArray(zclProps) && zclProps.length > 0) { return zclProps[0].category } and if (this.$store.state.zap.isMultiConfig) { return 'multiprotocol' } the same?
| // Picking the first category in the case of multi-protocol(zigbee/matter) | ||
| if (Array.isArray(zclProps) && zclProps.length > 0) { | ||
| return zclProps[0].category | ||
| } else { |
There was a problem hiding this comment.
Isn't if (Array.isArray(zclProps) && zclProps.length > 0) { return zclProps[0].category } and if (this.$store.state.zap.isMultiConfig) { return 'multiprotocol' } the same?
There was a problem hiding this comment.
Should this all be something like
if (this.$store.state.zap.isMultiConfig) { return 'multiprotocol' } else { return this.$store.state.zap.selectedZapConfig?.zclProperties.category }
There was a problem hiding this comment.
i think no, because if user choose two zigbee or two matter categories (if it is possible) they are not multiprotocol but zclProperties is an arrray. if it is not possible, you are right.
tbrkollar
force-pushed
the
feature/multiprotocolTheme
branch
from
dc3d954 to
2594e50
Compare
No description provided.