Update sql schema with on delete/update cascade #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he primary key is deleted or updated then the associated child tables are reflected for those deletes and updates properly. This should fix some of our sql constraint violations during inserts because sometimes we may just have leftover entries from deleted records. JIRA: ZAPP-1154
paulr34
approved these changes
Jun 12, 2024
tecimovic
approved these changes
Jun 13, 2024
| @@ -36,7 +36,7 @@ CREATE TABLE "PACKAGE" ( | |||
| "VERSION" integer, | |||
| "CATEGORY" text, | |||
| "DESCRIPTION" text, | |||
| foreign key (PARENT_PACKAGE_REF) references PACKAGE(PACKAGE_ID) | |||
| foreign key (PARENT_PACKAGE_REF) references PACKAGE(PACKAGE_ID) ON DELETE CASCADE ON UPDATE CASCADE | |||
There was a problem hiding this comment.
ON UPDATE CASCADE will update the foreign-key if someone updates the primary key.
Why and where are we ever updating primary keys?
There was a problem hiding this comment.
Update probably won't fix any underlying issues I know off.
Just a precaution more than anything else. I did not have a concrete reason to add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sql schema with on delete and update cascades such that when the primary key is deleted or updated then the associated child tables are reflected for those deletes and updates properly. This should fix some of our sql constraint violations during inserts because sometimes we may just have leftover entries from deleted records.
JIRA: ZAPP-1154