Fix attribute validation issues #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben1hop
force-pushed
the
ZAPP-1392
branch
2 times, most recently
from
6e2f970 to
4e8f40d
Compare
brdandu
approved these changes
Jun 13, 2024
| db, | ||
| attribType, | ||
| clusterRef, | ||
| packageIds |
There was a problem hiding this comment.
Hoping we don't have issues if 2 clusters define the same type name. 2 clusters can define a data type with the same name but different types and sizes.
There was a problem hiding this comment.
Wondering if keeping queryZcl.selectNumberByNameAndClusterId is safer but I will leave it to you.
There was a problem hiding this comment.
it does not work on some types , for example bitmaps
paulr34
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.