Sort clusters, commands and attributes in helper-endpointconfig.js #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
EndpointConfig_Sort
branch
2 times, most recently
from
40f5618 to
f116d84
Compare
vivien-apple
force-pushed
the
EndpointConfig_Sort
branch
from
f116d84 to
8dc29cd
Compare
|
Closing since @tecimovic did better thing by using |
|
I'm reopening this PR since it is still not fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While generating
endpoint_config.hthe attributes order is sometimes moving around. This is annoying since it creates some useless noises in PRs and it may hides some local changes.This PR sorts clusters, attributes and commands to make sure the order stay the same between multiple runs.