Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom style to notification #1135

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

tbrkollar
Copy link
Collaborator

No description provided.

@tbrkollar tbrkollar added the component: user interface User Interface work only, no backend label Sep 12, 2023
@tbrkollar tbrkollar self-assigned this Sep 12, 2023
@jingteng25742
Copy link
Contributor

@tbrkollar
I just tested out your change.
The adding / removing of the UC component window looks good.

The Required SLC Component not installed window still look the same and requires some theme / spacing update.

@tbrkollar
Copy link
Collaborator Author

tbrkollar commented Sep 14, 2023

Thanks @paulr34 and @jingteng25742 .

I modified the all notifies. Is this window a notify or a popup window? I searched and i think it is a popup window which is in ZCLDomainClusterView.vue file. In that case i have to create a new popup style.

@tbrkollar
Copy link
Collaborator Author

i ve already modified popup, please test it.
@jingteng25742 @paulr34

@tbrkollar
Copy link
Collaborator Author

rebase

@codecov-commenter
Copy link

Codecov Report

Merging #1135 (111798a) into master (142858f) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
- Coverage   65.21%   65.20%   -0.01%     
==========================================
  Files         170      170              
  Lines       18213    18213              
  Branches     3922     3922              
==========================================
- Hits        11877    11876       -1     
- Misses       6336     6337       +1     
Files Changed Coverage Δ
src/components/ZclDomainClusterView.vue 40.21% <ø> (-0.65%) ⬇️
src/util/util.js 24.19% <0.00%> (-0.40%) ⬇️
src/components/ZclCustomZclView.vue 47.12% <66.66%> (ø)

@paulr34 paulr34 force-pushed the custom-notification branch from 111798a to 9a0ee92 Compare September 15, 2023 15:00
@paulr34
Copy link
Collaborator

paulr34 commented Sep 15, 2023

tested, looks amazing. Rebasing and merging. Nice work @tbrkollar !

@paulr34 paulr34 force-pushed the custom-notification branch 3 times, most recently from a57b74a to bc94a52 Compare September 19, 2023 18:00
@jingteng25742
Copy link
Contributor

@tbrkollar
I'm seeing the following currently.
The color looks great but the spacing looks quite strange.
The "OTA Bootload.." is actually a list of items.
Making the list more indented / spaced better would be nice.
@tbrkollar I can show you how to reproduce the UI in Studio if testing is an issue.

Screenshot 2023-09-19 at 10 52 16 PM

@tbrkollar
Copy link
Collaborator Author

thanks, im working on it.

Copy link
Contributor

@jingteng25742 jingteng25742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested UI display Studio/ZAP on mac. approving.

@tbrkollar tbrkollar merged commit 7818be8 into project-chip:master Sep 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: user interface User Interface work only, no backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match Studio / UC component integration popup box color with ZAP theme colors
4 participants