Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support fabric-scoped commands #609

Closed
bzbarsky-apple opened this issue Jul 15, 2022 · 0 comments · Fixed by #611
Closed

Need to support fabric-scoped commands #609

bzbarsky-apple opened this issue Jul 15, 2022 · 0 comments · Fixed by #611
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK

Comments

@bzbarsky-apple
Copy link
Contributor

We need to be able to mark commands as fabric-scoped in the XML.

The relevant pieces are:

  1. Have isFabricScoped="true" in the XML on the relevant commands.
  2. Add a field to the COMMAND table to store the value (similar to MUST_USE_TIMED_INVOKE).
  3. Fix XML import to set the COMMAND field based on the XML.
  4. Allow some way to do things with fabric-scoped commands via helpers. Either expose the state in the data zcl_commands fetches, or have a custom helper like zcl_commands_that_need_timed_invoke; no really strong opinions here, though the zcl_commands approach seems a bit more flexible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant