-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An attribute that has "reportable=true" in the XML is not made reportable automatically #318
Comments
Note: this may or may not be a UI bug. It's possible that the bug happens in the back-end when the endpoint is created. We have to make sure that the database state itself is correct after creation of endpoint. |
In terms of the DB, if I examine the DB right after enabling the attribute on the endpoint the ATTRIBUTE table has IS_REPORTABLE true, but the ENDPOINT_TYPE_ATTRIBUTE has INCLUDED_REPORTABLE false for that attribute. So the UI and the DB are in sync; what I don't know is which is supposed to be the source of truth here. Obviously if I change things in the UI the DB gets updated. |
This should cause IS_REPORTABLE to be true for attributes unless the XML has reportable="false". Still waiting on project-chip/zap#318 to be fixed to then get us the behavior we really want.
This should cause IS_REPORTABLE to be true for attributes unless the XML has reportable="false". Still waiting on project-chip/zap#318 to be fixed to then get us the behavior we really want.
This should cause IS_REPORTABLE to be true for attributes unless the XML has reportable="false". Still waiting on project-chip/zap#318 to be fixed to then get us the behavior we really want.
Note that this bug is constantly corrupting the Matter .zap files: people add attributes, and forget to set them reportable, even though the spec requires them to be reportable. What's the chance for progress on this? |
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
This looks like it has been resolved in the consultant branch and can open a PR |
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
Attributes that have the "reportable" tag set operate like this:
1.) When you ENABLE the attribute on the "attribute" tab, they should immediatelly be made reportable, so if you go to "reporting" tab after enabling them, you should immediatelly see them enabled.
2.) If they are disabled later in the "reporting" tab, there should be a yellow triangle with a message "this attribute should be reportable" or something like that.
The text was updated successfully, but these errors were encountered: