Skip to content

Commit

Permalink
Fix accessor signatures for string/octstr attributes. (#1122)
Browse files Browse the repository at this point in the history
* Fix accessor signatures for string/octstr attributes.

See project-chip/connectedhomeip#28357: we are not
mutating the actual value the caller will observe.

* Address review comment.
  • Loading branch information
bzbarsky-apple authored Sep 1, 2023
1 parent 1aa832c commit d11b495
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ async function accessorGetterType(attr) {
type = `DataModel::Nullable<${type}> &`;
} else if (mayNeedPointer) {
type = `${type} *`;
} else {
type = `${type} &`;
}

return type;
Expand Down

0 comments on commit d11b495

Please sign in to comment.