load attribute when open zap file

project-chip · Dec 6, 2024 · 1b71a78 · 1b71a78
1 parent 4bc1bdb
commit 1b71a78
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 14 deletions.
diff --git a/src-electron/db/query-attribute.js b/src-electron/db/query-attribute.js
@@ -1250,13 +1250,17 @@ async function selectAttributeMappingsByPackageIds(db, packageIds) {
 
 /**
  * Get all attributes in an endpoint type cluster
+ * Disabled attributes are not loaded into ENDPOINT_TYPE_ATTRIBUTE table
+ * when opening a ZAP file, so we need to join DEVICE_TYPE_ATTRIBUTE table
  * @param {*} db
  * @param {*} endpointTyeClusterId
+ * @param {*} deviceTypeClusterId
  * @returns all attributes in an endpoint type cluster
  */
-async function selectAttributesByEndpointTypeClusterId(
+async function selectAttributesByEndpointTypeClusterIdAndDeviceTypeClusterId(
   db,
-  endpointTyeClusterId
+  endpointTypeClusterId,
+  deviceTypeClusterId
 ) {
   let rows = await dbApi.dbAll(
     db,
@@ -1274,13 +1278,19 @@ async function selectAttributesByEndpointTypeClusterId(
     FROM
       ATTRIBUTE
     JOIN
+      DEVICE_TYPE_CLUSTER
+    ON
+      ATTRIBUTE.CLUSTER_REF = DEVICE_TYPE_CLUSTER.CLUSTER_REF
+    LEFT JOIN
       ENDPOINT_TYPE_ATTRIBUTE
     ON
-      ATTRIBUTE.ATTRIBUTE_ID = ENDPOINT_TYPE_ATTRIBUTE.ATTRIBUTE_REF
+        ATTRIBUTE.ATTRIBUTE_ID = ENDPOINT_TYPE_ATTRIBUTE.ATTRIBUTE_REF
+      AND
+        ENDPOINT_TYPE_ATTRIBUTE.ENDPOINT_TYPE_CLUSTER_REF = ?
     WHERE
-      ENDPOINT_TYPE_ATTRIBUTE.ENDPOINT_TYPE_CLUSTER_REF = ?
+      DEVICE_TYPE_CLUSTER.DEVICE_TYPE_CLUSTER_ID = ?
     `,
-    [endpointTyeClusterId]
+    [endpointTypeClusterId, deviceTypeClusterId]
   )
   return rows.map(dbMapping.map.endpointTypeAttributeExtended)
 }
@@ -1311,5 +1321,5 @@ exports.selectTokenAttributesForEndpoint = selectTokenAttributesForEndpoint
 exports.selectAllUserTokenAttributes = selectAllUserTokenAttributes
 exports.selectAttributeMappingsByPackageIds =
   selectAttributeMappingsByPackageIds
-exports.selectAttributesByEndpointTypeClusterId =
-  selectAttributesByEndpointTypeClusterId
+exports.selectAttributesByEndpointTypeClusterIdAndDeviceTypeClusterId =
+  selectAttributesByEndpointTypeClusterIdAndDeviceTypeClusterId
diff --git a/src-electron/rest/user-data.js b/src-electron/rest/user-data.js
@@ -112,9 +112,10 @@ async function getEndpointTypeElements(
   deviceTypeClusterId
 ) {
   let [attributes, commands, events] = await Promise.all([
-    queryAttribute.selectAttributesByEndpointTypeClusterId(
+    queryAttribute.selectAttributesByEndpointTypeClusterIdAndDeviceTypeClusterId(
       db,
-      endpointTypeClusterId
+      endpointTypeClusterId,
+      deviceTypeClusterId
     ),
     queryCommand.selectCommandsByEndpointTypeClusterIdAndDeviceTypeClusterId(
       db,

diff --git a/test/query.test.js b/test/query.test.js
@@ -623,10 +623,10 @@ describe('Endpoint Type Config Queries', () => {
       let expectedNumbers = {
         Identify: {
           server: { attributes: 2, commands: 6 },
-          client: { attributes: 1, commands: 6 }
+          client: { attributes: 2, commands: 6 }
         },
-        Basic: { server: { attributes: 3, commands: 1 } },
-        'On/off': { client: { attributes: 1, commands: 11 } }
+        Basic: { server: { attributes: 18, commands: 1 } },
+        'On/off': { client: { attributes: 9, commands: 11 } }
       }
       let deviceTypeClusters =
         await queryDeviceType.selectDeviceTypeClustersByDeviceTypeRef(
@@ -646,9 +646,10 @@ describe('Endpoint Type Config Queries', () => {
             if (deviceTypeCluster) {
               let deviceTypeClusterId = deviceTypeCluster.id
               queryAttribute
-                .selectAttributesByEndpointTypeClusterId(
+                .selectAttributesByEndpointTypeClusterIdAndDeviceTypeClusterId(
                   db,
-                  endpointTypeClusterId
+                  endpointTypeClusterId,
+                  deviceTypeClusterId
                 )
                 .then((attributes) => {
                   expect(attributes.length).toBe(