Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcements optimizations #64

Merged
merged 10 commits into from
Apr 9, 2023
Merged

Announcements optimizations #64

merged 10 commits into from
Apr 9, 2023

Conversation

Apollon77
Copy link
Collaborator

This PR brings several enhancements for announcements, like

Notes: The handling with overlapping of announcements and an opened additional commissioning window is not perfect, but that topic will be restructured soon anyway for high level API when bringing all together. It works as needed for now

@Apollon77 Apollon77 requested review from turon and mfucci March 19, 2023 17:06
@vves
Copy link
Collaborator

vves commented Mar 19, 2023

@Apollon77 I take it that node-matter if fully abandoned now and this PR sorts out some of the issues you and I were working on in the previous library?

@Apollon77
Copy link
Collaborator Author

@vves basicslly yes. I took over the announcement interface from your PR but left out the "still in discussion" IPv6 topic because i still do not understand why you have issues.

That's why I left the PR in node-matter open and we continue discuss there. Or you open a new PR in matter.js (Code places are same-ish)

@Apollon77
Copy link
Collaborator Author

@turon I adjusted Readme to better state what the announceinterface is for and I answered your other comments. Announcement will also be adjusted with high level API

@Apollon77 Apollon77 requested a review from turon April 3, 2023 18:20
@vves
Copy link
Collaborator

vves commented Apr 3, 2023

Additionally - the importance of the announceinterface is that on multi-nic systems, each network interface will announce a different *.local mdns name. In my case, I have two physical and one virtual nic and I have three different devices announced on mdns unless a single interface is selected.

Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving away from hard-coded port!

@Apollon77 Apollon77 merged commit 41d829e into project-chip:main Apr 9, 2023
@Apollon77 Apollon77 deleted the announcerevamp branch April 9, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants