-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort PASE session establishment process if not completed within 60 seconds #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
September 27, 2021 20:55
woody-apple
approved these changes
Sep 28, 2021
msandstedt
approved these changes
Sep 28, 2021
pan-apple
force-pushed
the
pase-timeout-60
branch
from
September 28, 2021 15:28
b94d6f0
to
d3dba16
Compare
Size increase report for "gn_qpg-example-build" from a3af3ac
Full report output
|
saurabhst
approved these changes
Sep 28, 2021
yufengwangca
approved these changes
Sep 28, 2021
Size increase report for "esp32-example-build" from a3af3ac
Full report output
|
Size increase report for "nrfconnect-example-build" from a3af3ac
Full report output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As per specifications (section 5.5 Commissioning Flows), the PASE session establishment process must terminate if the process is not completed within 60 seconds. This needs to be enforced in the SDK code.
Change overview
Add callback in the delegate to get notified on starting of session establishment process.
Start a timer when the process starts.
If the process doesn't finish within the timeout period, abort the current session establishment process.
Testing
Tested it manually by not sending Pake1 message during the session establishment. Ensured that the current session is aborted, and the device starts advertisement for the session establishment availability. A new PAKE session can be established with the device at this point.