Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort PASE session establishment process if not completed within 60 seconds #9997

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

As per specifications (section 5.5 Commissioning Flows), the PASE session establishment process must terminate if the process is not completed within 60 seconds. This needs to be enforced in the SDK code.

Change overview

Add callback in the delegate to get notified on starting of session establishment process.
Start a timer when the process starts.
If the process doesn't finish within the timeout period, abort the current session establishment process.

Testing

Tested it manually by not sending Pake1 message during the session establishment. Ensured that the current session is aborted, and the device starts advertisement for the session establishment availability. A new PAKE session can be established with the device at this point.

@woody-apple
Copy link
Contributor

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from a3af3ac

File Section File VM
chip-qpg6100-lighting-example.out .text 104 104
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,823
.debug_loc,0,373
.debug_line,0,351
.debug_str,0,249
.strtab,0,219
.debug_ranges,0,152
.symtab,0,112
.text,104,104
.debug_frame,0,76
.debug_aranges,0,32
.debug_abbrev,0,20
.shstrtab,0,1
[Unmapped],0,-104


@github-actions
Copy link

Size increase report for "esp32-example-build" from a3af3ac

File Section File VM
chip-all-clusters-app.elf .flash.text 116 116
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,798
.debug_line,0,474
.debug_loc,0,253
.debug_str,0,246
.strtab,0,219
.flash.text,116,116
.debug_ranges,0,112
.debug_frame,0,52
.symtab,0,48
.debug_aranges,0,24
.shstrtab,0,1
.debug_abbrev,0,-27
[Unmapped],0,-116


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from a3af3ac

File Section File VM
chip-lock.elf text 88 88
chip-lock.elf device_handles 8 8
chip-lock.elf rodata 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,690
.debug_loc,0,354
.debug_line,0,278
.debug_str,0,246
.strtab,0,219
.debug_ranges,0,128
.symtab,0,112
text,88,88
.debug_frame,0,60
.debug_aranges,0,24
.debug_abbrev,0,20
device_handles,8,8
rodata,8,8
.shstrtab,0,1


@woody-apple woody-apple merged commit a107895 into project-chip:master Sep 28, 2021
@pan-apple pan-apple deleted the pase-timeout-60 branch September 28, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants