Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call DRBG_get_bytes() For Subscription Id Generation. #9995

Conversation

emargolis
Copy link
Contributor

Problem

#9716

Change overview

Call DRBG_get_bytes() For Subscription Id Generation.

Testing

Unit testing

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 50ad13f

File Section File VM
chip-qpg6100-lighting-example.out .text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,165
.debug_loc,0,95
.debug_line,0,40
.debug_abbrev,0,20
.text,16,16
[Unmapped],0,-16
.debug_ranges,0,-24

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 50ad13f

File Section File VM
chip-lock.elf text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,161
.debug_loc,0,64
.debug_line,0,43
.debug_abbrev,0,20
text,16,16

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build" from 50ad13f

File Section File VM
chip-all-clusters-app.elf .flash.text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,61
.debug_loc,0,55
.debug_ranges,0,24
.debug_abbrev,0,20
[Unmapped],0,12
.debug_line,0,11
.shstrtab,0,3
.riscv.attributes,0,-3
.flash.text,-12,-12
.symtab,0,-16
.strtab,0,-23


@andy31415 andy31415 merged commit 3b15fd5 into project-chip:master Sep 28, 2021
@emargolis emargolis deleted the emargolis/feature/use-drbg-to-generate-subscription-id branch December 14, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants