Remove IP rendezvous flags, fix chip-tool. #9993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes previous issue where we were getting too many device connected callbacks and advancing the commissioning stage too quickly.
andy31415
approved these changes
Sep 27, 2021
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
vivien-apple and
woody-apple
saurabhst
approved these changes
Sep 27, 2021
bzbarsky-apple
approved these changes
Sep 27, 2021
andy31415
pushed a commit
that referenced
this pull request
Sep 27, 2021
Fixes previous issue where we were getting too many device connected callbacks and advancing the commissioning stage too quickly.
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Sep 28, 2021
Fixes previous issue where we were getting too many device connected callbacks and advancing the commissioning stage too quickly.
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 15, 2021
Fixes previous issue where we were getting too many device connected callbacks and advancing the commissioning stage too quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
re-upload of #9892 with fix for break.
Change overview
Fixes previous issue where we were getting too many device connected
callbacks and advancing the commissioning stage too quickly.
Testing
Commissioned ip device on chip-tool and chip-device-ctrl. Passes tests on ToT.