Fix Identify cluster callback handling #9988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current identify cluster could only handle one identify request without an error. After that it would get stuck and would not perform another identify start callback.
bauerschwan
approved these changes
Sep 27, 2021
|
@woody-apple @andy31415 would be great if this would land in the TE6 branch. |
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple and
turon
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
tcarmelveilleux
changed the title
|
Size increase report for "esp32-example-build" from 4bafdcf
Full report output |
tcarmelveilleux
approved these changes
Sep 28, 2021
woody-apple
approved these changes
Sep 28, 2021
saurabhst
approved these changes
Sep 28, 2021
andy31415
pushed a commit
that referenced
this pull request
Sep 28, 2021
* fix idenitfy cluster callback handling The current identify cluster could only handle one identify request without an error. After that it would get stuck and would not perform another identify start callback. * make compiler & CI happy * refactor activate logic in identify-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The internal state of the identify cluster has a bug. This prevents the proper handling of another identify request. This PR fixes this.
Testing
On a nordic based board.