-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CCM encrypt/decrypt for 0 byte plaintext #9973
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
pan-apple:crypto-case-resume
Sep 27, 2021
Merged
Enable CCM encrypt/decrypt for 0 byte plaintext #9973
bzbarsky-apple
merged 2 commits into
project-chip:master
from
pan-apple:crypto-case-resume
Sep 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
sagar-apple,
saurabhst,
shana-apple,
turon,
vivien-apple,
woody-apple and
yunhanw-google
September 24, 2021 22:46
msandstedt
approved these changes
Sep 24, 2021
Size increase report for "gn_qpg-example-build" from bb7e53f
Full report output
|
Size increase report for "nrfconnect-example-build" from bb7e53f
Full report output
|
Size increase report for "esp32-example-build" from bb7e53f
Full report output
|
emargolis
approved these changes
Sep 25, 2021
bzbarsky-apple
approved these changes
Sep 27, 2021
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 15, 2021
* Enable CCM encrypt/decrypt for 0 byte plaintext * check for buffer allocation iff length > 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CASE resumption requires encrypt/decrypt for 0 byte sized values. The generated tag/MIC is actually used for session resumption. The current
CHIPCrypto
code is expecting the input buffer to be > 0 length.Change overview
Remove the check, and update unit tests to verify 0 byte crypto operations.
Testing
Enabled checks for test vectors of 0 byte inputs in
CHIPCryptoPALTest
.