Add initial codegen support for Cluster object #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
requested review from
erjiaqing,
mrjerryjohns and
bzbarsky-apple
yunhanw-google
requested review from
vivien-apple,
andy31415,
msandstedt and
jmartinez-silabs
yunhanw-google
force-pushed
the
feature/update_codegen3
branch
from
10cb962 to
b988b03
Compare
|
Need to add the BUILD.gn for the cluster-objects library as a dependency to all the existing sample apps. |
zzz_generated/lighting-app/zap-generated/IMClusterCommandHandler.cpp
Outdated
Show resolved
Hide resolved
yunhanw-google
force-pushed
the
feature/update_codegen3
branch
from
b988b03 to
8a92045
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mspang and
pan-apple
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
woody-apple and
yufengwangca
yunhanw-google
force-pushed
the
feature/update_codegen3
branch
from
8a92045 to
ddef21b
Compare
|
mrjerryjohns
approved these changes
Sep 25, 2021
yunhanw-google
force-pushed
the
feature/update_codegen3
branch
from
ddef21b to
323ad8a
Compare
jmartinez-silabs
approved these changes
Sep 27, 2021
woody-apple
approved these changes
Sep 28, 2021
msandstedt
approved these changes
Sep 28, 2021
ghost
reviewed
Sep 30, 2021
| namespace clusters { | ||
|
|
||
| namespace AccountLogin { | ||
| constexpr ClusterId kClusterId = 0x50E; |
There was a problem hiding this comment.
This here is a duplication of information? zzz_generated/app-common/app-common/zap-generated/ids/Clusters.h contains this information. Wouldn't it be better to reference this?
ghost
reviewed
Sep 30, 2021
Comment on lines
+50
to
+56
| enum class ApplicationBasicStatus : uint8_t | ||
| { | ||
| APPLICATION_BASIC_STATUS_STOPPED = 0x00, | ||
| APPLICATION_BASIC_STATUS_ACTIVE_VISIBLE_FOCUS = 0x01, | ||
| APPLICATION_BASIC_STATUS_ACTIVE_HIDDEN = 0x02, | ||
| APPLICATION_BASIC_STATUS_ACTIVE_VISIBLE_NOT_FOCUS = 0x03, | ||
| }; |
There was a problem hiding this comment.
This here is a dupplicate of zzz_generated/app-common/app-common/zap-generated/enums.h -> EmberAfApplicationBasicStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix #8895
Change overview
Add initial codegen support for Cluster object
Testing
The existing unit test covers this.