Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove ip cluster flags" #9970

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

yunhanw-google
Copy link
Contributor

Reverts #9892
CI is broken in cirque and linux test, try to revert this and see if the ci becomes green

@merge-mamba
Copy link

merge-mamba bot commented Sep 24, 2021

Potential Conflict Warning

This pull request has changes that overlap with branches below. You might want to check in with the other
branch authors before you merge to avoid a conflict. 🐍

revert-9677-im/subscription-test-followup (@woody-apple)

restyled/pull-9310 (@tecimovic @restyled-commits)

Something wrong? Got a suggestion? Email me or leave feedback here.

@cecille
Copy link
Contributor

cecille commented Sep 24, 2021

Build was green when this PR was merged. So there's got to be some fancy business with the merge or something. If this makes things green, just revert and I'll resubmit on Monday.

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Sep 24, 2021
@andy31415
Copy link
Contributor

Merging as hotfix: cirque and Linux tests pass (then again so did the original PR :( )

@andy31415 andy31415 merged commit eed0bae into master Sep 24, 2021
@andy31415 andy31415 deleted the revert-9892-remove_ip_cluster_flags branch September 24, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app controller documentation Improvements or additions to documentation examples hotfix urgent fix needed, can bypass review platform review - pending scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants