Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ReliableMessageMgr::mRetransTable to Pool #9951

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Sep 24, 2021

Problem

The Pool provides a more robust RAII style interface than a raw array.

Change overview

Use Pool interface for ReliableMessageMgr::mRetransTable

Testing

Verified by unit-tests

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 77a9f6a

File Section File VM
chip-qpg6100-lighting-example.out .bss 0 16
chip-qpg6100-lighting-example.out .heap 0 -16
chip-qpg6100-lighting-example.out .text -164 -164
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,30739
.debug_str,0,6803
.debug_abbrev,0,1424
.debug_loc,0,1027
.strtab,0,981
.debug_line,0,339
.debug_ranges,0,264
.symtab,0,208
[Unmapped],0,164
.debug_frame,0,72
.debug_aranges,0,48
.bss,16,0
.shstrtab,0,-1
.heap,-16,0
.text,-164,-164

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 77a9f6a

File Section File VM
chip-shell.elf bss 0 32
chip-shell.elf rodata -48 -48
chip-shell.elf text -112 -112
chip-lock.elf bss 0 28
chip-lock.elf device_handles 8 8
chip-lock.elf [LOAD #3 [RW]] 0 -28
chip-lock.elf rodata -48 -48
chip-lock.elf text -136 -136
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,13477
.debug_str,0,6792
.debug_loc,0,1352
.strtab,0,1117
.debug_abbrev,0,376
.debug_line,0,331
.debug_ranges,0,256
.symtab,0,256
.debug_frame,0,72
.debug_aranges,0,48
bss,32,0
.shstrtab,0,-1
rodata,-48,-48
text,-112,-112

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,30057
.debug_str,0,6802
.debug_abbrev,0,1384
.debug_loc,0,1222
.strtab,0,981
.debug_line,0,311
.debug_ranges,0,240
.symtab,0,208
.debug_frame,0,72
.debug_aranges,0,48
bss,28,0
device_handles,8,8
.shstrtab,0,3
[LOAD #3 [RW]],-28,0
rodata,-48,-48
text,-136,-136


@github-actions
Copy link

Size increase report for "esp32-example-build" from 77a9f6a

File Section File VM
chip-all-clusters-app.elf .dram0.bss 0 16
chip-all-clusters-app.elf .flash.rodata -48 -48
chip-all-clusters-app.elf .flash.text -152 -152
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,46425
.debug_str,0,7488
.debug_abbrev,0,2584
.strtab,0,981
.debug_loc,0,343
[Unmapped],0,200
.debug_ranges,0,152
.symtab,0,112
.debug_frame,0,76
.debug_aranges,0,64
.dram0.bss,16,0
.riscv.attributes,0,-1
.shstrtab,0,-1
.flash.rodata,-48,-48
.debug_line,0,-135
.flash.text,-152,-152


@woody-apple woody-apple merged commit 6145b34 into project-chip:master Sep 29, 2021
@kghost kghost deleted the rmp-pool branch September 30, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants