Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ./scripts/tools/zap_convert_all.py #9949

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

vivien-apple
Copy link
Contributor

Problem

Some *.zap files are out of sync.

Change overview

  • Run ./scripts/tools/zap_convert_all.py to update zap files
  • Run `./scripts/tools/zap_regen_all.py to generate content from the updated files and observe that nothing has changed

Testing

Code output has not changed.

@andy31415
Copy link
Contributor

For my own knowledge: what does 'out of sync' mean? what does 'updating zap files' mean?

It seems to me like we have zap as input, but this depends on other input (xml files?). Is this the case? If so, could we open a bug against zap to only have a single source of truth and not require such updates like this one?

@andy31415 andy31415 merged commit 99aec53 into project-chip:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants