-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform] remove legacy functions in ConnectivityManager #9946
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
gjc13:trim-connectivity-manager
Sep 27, 2021
Merged
[platform] remove legacy functions in ConnectivityManager #9946
yufengwangca
merged 1 commit into
project-chip:master
from
gjc13:trim-connectivity-manager
Sep 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
September 24, 2021 05:51
pullapprove
bot
requested review from
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple and
yufengwangca
September 24, 2021 05:51
Damian-Nordic
approved these changes
Sep 24, 2021
* Remove unused function `HaveIPv4InternetConnectivity` and `HaveIPv6InternetConnectivity`. * Service connectivity is legacy concept and not well defined. Remove `HaveServiceConnectivity`
gjc13
force-pushed
the
trim-connectivity-manager
branch
from
September 26, 2021 03:07
b12c3c5
to
9436c0c
Compare
Size increase report for "gn_qpg-example-build" from 45715cc
Full report output
|
Size increase report for "nrfconnect-example-build" from 45715cc
Full report output
|
andy31415
approved these changes
Sep 27, 2021
msandstedt
approved these changes
Sep 27, 2021
yufengwangca
approved these changes
Sep 27, 2021
andy31415
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Remove unused function `HaveIPv4InternetConnectivity` and `HaveIPv6InternetConnectivity`. * Service connectivity is legacy concept and not well defined. Remove `HaveServiceConnectivity`
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 15, 2021
…ip#9946) * Remove unused function `HaveIPv4InternetConnectivity` and `HaveIPv6InternetConnectivity`. * Service connectivity is legacy concept and not well defined. Remove `HaveServiceConnectivity`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
HaveIPv4InternetConnectivity
andHaveIPv6InternetConnectivity
are not used.Change overview
Remove these functions from
ConnectivityManager
.Testing
How was this tested? (at least one bullet point required)