[ota-provider-app] fix ExchangeManager singleton access method #9943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple and
woody-apple
bzbarsky-apple
approved these changes
Sep 24, 2021
carol-apple
approved these changes
Sep 24, 2021
yufengwangca
approved these changes
Sep 24, 2021
LuDuda
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ota-provider-appneeds access toExchangeManagerin order to set anUnsolicitedMessageHandlerfor BDX messages.It was getting access via
chip::ExchangeManager()insrc/app/util/util.hwhich is somewhat out of date and not used by any other code paths now.Change overview
Server::GetExchangeManager()to get access to theExchangeManagerinstantiated by theServersingletonTesting
Confirmed full OTA transfer occurs using
ota-provider-appandota-requestor-app