Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python]:Disable OriginalSetupCode option in command 'open-commissioning-window' #9942

Merged
merged 1 commit into from
Sep 27, 2021
Merged

[python]:Disable OriginalSetupCode option in command 'open-commissioning-window' #9942

merged 1 commit into from
Sep 27, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Sep 24, 2021

Problem

What is being fixed? Examples:

  • Feedback from CSG, Option [OriginalSetupCode = 0] in python command 'open-commissioning-window' is used to open Basic Commissioning Window(BCM), 'open-commissioning-window' is supposed to open extended commissioning(ECM) only since there is already a separate command for BCM.

Change overview

Disable OriginalSetupCode option in command 'open-commissioning-window'

Testing

How was this tested? (at least one bullet point required)

chip-device-ctrl > open-commissioning-window 12344321 -t 3 -o 0 -d 3840 -i 1000
Invalid option specified!

open-commissioning-window <nodeid> [options]

Options:
  -t  Timeout (in seconds)     
  -o  Option  [TokenWithRandomPIN = 1, TokenWithProvidedPIN = 2]
  -d  Discriminator Value
  -i  Iteration

  This command is used by a current Administrator to instruct a Node to go into commissioning mode

@yufengwangca yufengwangca merged commit 242a197 into project-chip:master Sep 27, 2021
@yufengwangca yufengwangca deleted the pr/python/admin branch September 27, 2021 18:56
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants