-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 3 more Yamls ( Test_TC_TM_2_1,Test_TC_TSUIC_2_1,Test_TC_PCC_2_1) #9931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple and
saurabhst
September 23, 2021 18:46
pullapprove
bot
requested review from
shana-apple,
turon,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
September 23, 2021 18:46
Size increase report for "nrfconnect-example-build" from e1f3aa1
Full report output
|
andy31415
approved these changes
Sep 23, 2021
bzbarsky-apple
approved these changes
Sep 23, 2021
woody-apple
approved these changes
Sep 24, 2021
saurabhst
approved these changes
Sep 28, 2021
Damian-Nordic
approved these changes
Sep 28, 2021
@raju-apple - conflicts |
|
jmartinez-silabs
approved these changes
Sep 28, 2021
Looks like I need to regenerate the code and submit the PR again , created a new PR with more changes to some of the existing Yamls , will merge that in instead . #10050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 3 more Yamls :
Test_TC_TM_2_1 : Temperature Measurement Cluster
Test_TC_TSUIC_2_1 : Thermostat User Interface Configuration Cluster
Test_TC_PCC_2_1 : Pump Configuration and Control Cluster
Bunch of steps are still disabled for the following reasons :
null
and types likeuint16
,desc
need to still be implemented by the yaml framework as well so still disabled.