Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xml #9912

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Sep 23, 2021

Problem

In order to add support for complicated type for issue 8895, we need explicitly to mark struct item as array=true for array processing inside struct, the zap has already added the support for array query and check.
We need to update xml with array for struct item

Change overview

--update xml with array for struct item
--update InterfaceType for NetworkInterfaceType struct

Testing

How was this tested? (at least one bullet point required)
Compilation and presubmit validation.

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are the other changes required by the ZAP update? If not, we should have one PR that does the ZAP update and minimal other changes, and a second PR for whatever changes are not related to the update.

@yunhanw-google
Copy link
Contributor Author

yunhanw-google commented Sep 23, 2021

Also, are the other changes required by the ZAP update? If not, we should have one PR that does the ZAP update and minimal other changes, and a second PR for whatever changes are not related to the update.
No need to update zap now, just update the PR, please take a further look, @bzbarsky-apple thanks

--update xml with array for struct item
--update InterfaceType for NetworkInterfaceType struct
@yunhanw-google yunhanw-google merged commit 327a471 into project-chip:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants