Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address GitHub Issue 98: 'make distcheck' Failure #99

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Address GitHub Issue 98: 'make distcheck' Failure #99

merged 2 commits into from
Mar 24, 2020

Conversation

gerickson
Copy link
Contributor

Problem

This addresses GitHub issue #98 in which 'make distcheck' fails.

Summary of Changes

  • Include PLATFORM_SUBDIRS rather than MAYBE_PLATFORM_SUBDIRS in DIST_SUBDIRS to ensure 'platform' is picked up on 'make dist'.
  • Qualify headers to ensure that they can be found during 'make dist' and 'make install'.

Fixes #98

Grant Erickson added 2 commits March 23, 2020 17:21
turon
turon approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Makefile.am
@@ -54,10 +73,4 @@ SUBDIRS = \
$(MAYBE_PLATFORM_SUBDIRS) \
$(NULL)

if CONFIG_NETWORK_LAYER_BLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this pattern and apply it to CONFIG_DEVICE_LAYER as well?
It seems easier to read and more maintainable than MAYBE_..._SUBDIRS , also it follows the OpenThread pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I only want to write <directory name> once.

@turon turon mentioned this pull request Mar 24, 2020
Closed
@woody-apple woody-apple merged commit 85705ae into project-chip:master Mar 24, 2020
@gerickson gerickson deleted the user/gerickson/github-issue-98 branch March 24, 2020 00:58
mkardous-silabs referenced this pull request in SiliconLabs/watt-sandbox Oct 6, 2022
@jepenven-silabs @mkardous-silabs
Pull request SiliconLabs#99: Fix code size error
97e5ec2 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this pull request Oct 19, 2022
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#99: Fix code size error
1a2f05a 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Oct 24, 2022
@jepenven-silabs @jmartinez-silabs
Pull request #99: Fix code size error
8867d7d 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
@jepenven-silabs @jmartinez-silabs
Pull request #99: Fix code size error
9227174 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
domichae-amazon pushed a commit to domichae-amazon/connectedhomeip that referenced this pull request Feb 27, 2023
@sharadb-amazon @cliffamzn
Android: Ensuring DNS-SD service is discoverable before calling NsdMa…
fcd23bc 
…nager.resolveService() (project-chip#99)

* Android: Ensuring DNS-SD service is discoverable  before calling NsdManager.resolveService()

* Addressing feedback from cliffamzn@

* Stopping discovery and cancelling corresponding ScheduledFuture when service is found

* Update src/platform/android/java/chip/platform/NsdServiceFinderAndResolver.java

Co-authored-by: Cliff Chung <[email protected]>

---------

Co-authored-by: Cliff Chung <[email protected]>
chrisdecenzo pushed a commit that referenced this pull request Mar 10, 2023
@sharadb-amazon @cliffamzn
Android: Ensuring DNS-SD service is discoverable before calling NsdMa…
7541b49 
…nager.resolveService() (#99) (#25597)

* Android: Ensuring DNS-SD service is discoverable  before calling NsdManager.resolveService()

* Addressing feedback from cliffamzn@

* Stopping discovery and cancelling corresponding ScheduledFuture when service is found

* Update src/platform/android/java/chip/platform/NsdServiceFinderAndResolver.java



---------

Co-authored-by: Cliff Chung <[email protected]>
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@sharadb-amazon @cliffamzn
Android: Ensuring DNS-SD service is discoverable before calling NsdMa…
cc6ae65 
…nager.resolveService() (project-chip#99) (project-chip#25597)

* Android: Ensuring DNS-SD service is discoverable  before calling NsdManager.resolveService()

* Addressing feedback from cliffamzn@

* Stopping discovery and cancelling corresponding ScheduledFuture when service is found

* Update src/platform/android/java/chip/platform/NsdServiceFinderAndResolver.java



---------

Co-authored-by: Cliff Chung <[email protected]>
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@sharadb-amazon @cliffamzn @mwswartwout
Android: Ensuring DNS-SD service is discoverable before calling NsdMa…
decedf4 
…nager.resolveService() (project-chip#99) (project-chip#25597)

* Android: Ensuring DNS-SD service is discoverable  before calling NsdManager.resolveService()

* Addressing feedback from cliffamzn@

* Stopping discovery and cancelling corresponding ScheduledFuture when service is found

* Update src/platform/android/java/chip/platform/NsdServiceFinderAndResolver.java



---------

Co-authored-by: Cliff Chung <[email protected]>
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#99: Fix code size error
0986fa6 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#99: Fix code size error
0de5f14 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this pull request Jul 18, 2024
@jepenven-silabs @jmartinez-silabs
Pull request project-chip#99: Fix code size error
780d7b9 
Merge in WMN_TOOLS/matter from fix_code_size_error to silabs

Squashed commit of the following:

commit 19533a4ebb9ae7ae5af878e4f55fda52ae878ec5
Author: jepenven-silabs <[email protected]>
Date:   Wed Sep 14 15:01:56 2022 -0400

    Fix code size error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@turon turon turon approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failing
3 participants
@gerickson @turon @woody-apple