Add cluster id code for struct and enum in xml #9881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cluster id for enum and struct to create relathship between cluster and enum/struct.
yunhanw-google
requested review from
andy31415,
msandstedt,
erjiaqing,
mrjerryjohns,
bzbarsky-apple,
vivien-apple and
jmartinez-silabs
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
kghost,
LuDuda,
mlepage-google,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
woody-apple
yunhanw-google
force-pushed
the
feature/update_xml_struct
branch
from
13c5408 to
753bef3
Compare
Damian-Nordic
approved these changes
Sep 22, 2021
saurabhst
approved these changes
Sep 22, 2021
src/app/zap-templates/zcl/data-model/chip/administrator-commissioning-cluster.xml
Show resolved
Hide resolved
mrjerryjohns
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
While the embedded of cluster-id inside each status code vs. just moving that under the tag is more right answer here, let's merge this to unblock other work. Once this ZAP issue is fixed, we can change it to the right format.
jmartinez-silabs
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to add support for complicated type for issue 8895, we need to build relationship between cluster and struct/enum. Latest zap has added support to build relationship between cluster and struct/enum via cluster id code within struct and enum.
We need to update xml with cluster id code for struct and enum
Change overview
update xml with cluster id code for struct and enum
Testing
How was this tested? (at least one bullet point required)
Compilation.