-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement miscellaneous OTA Provider cluster spec changes #9874
Merged
holbrookt
merged 12 commits into
project-chip:master
from
holbrookt:ota-clusters-update
Sep 30, 2021
Merged
Implement miscellaneous OTA Provider cluster spec changes #9874
holbrookt
merged 12 commits into
project-chip:master
from
holbrookt:ota-clusters-update
Sep 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename CurrentVersion attribute to SoftwareVersion Remove ImageType field of ImageQuery Change accepted length of UpdateToken Add SoftwareVersionString field to QueryImageResponse Rename CriticalUpdateAvailable to UrgentUpdateAvailable
(#5542): The cluster handlers should accept a ByteSpan for all string types.connectedhomeip/zzz_generated/controller-clusters/zap-generated/IMClusterCommandHandler.cpp Lines 4081 to 4091 in 1e2b55d
This comment was generated by todo based on a
|
(#5542): The cluster handlers should accept a ByteSpan for all string types.connectedhomeip/zzz_generated/ota-requestor-app/zap-generated/IMClusterCommandHandler.cpp Lines 187 to 197 in 1e2b55d
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
September 22, 2021 00:02
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
September 22, 2021 00:03
woody-apple
approved these changes
Sep 22, 2021
selissia
approved these changes
Sep 23, 2021
carol-apple
reviewed
Sep 23, 2021
carol-apple
reviewed
Sep 23, 2021
carol-apple
approved these changes
Sep 24, 2021
tcarmelveilleux
approved these changes
Sep 29, 2021
chrisdecenzo
approved these changes
Sep 30, 2021
jmartinez-silabs
approved these changes
Sep 30, 2021
Size increase report for "esp32-example-build" from 663cfc6
Full report output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since much of the OTA code was written, there have been a number of changes to the cluster spec definitions that have not been reflected in the code. These include name changes to attributes and/or command arguments, removing/adding arguments to commands, and changing size requirements of one command argument. See the full list below.
Change overview
This PR does not bring OTA fully up to spec. Still need to implement events and related changes.
Testing
In one terminal:
In a second terminal:
Verified image transfer completes successfully.