Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer logging of exchange ids. #9861

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Exchange ids are scoped to the initiator, so a bare exchange id does
not uniquely identify he exchange. For now, just log with each id
whether we are the initiator or the responder, which should at least
help disambiguate that.

Problem

See above.

Change overview

See above.

Testing

No behavior changes, other than logging output.

Exchange ids are scoped to the initiator, so a bare exchange id does
not uniquely identify he exchange.  For now, just log with each id
whether we are the initiator or the responder, which should at least
help disambiguate that.
@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 1d12139

File Section File VM
chip-qpg6100-lighting-example.out .text 220 220
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,544
.debug_loc,0,330
.text,220,220
.debug_ranges,0,152
.debug_line,0,146
.strtab,0,52
.debug_frame,0,44
.symtab,0,32
[Unmapped],0,-220

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "esp32-example-build" from 1d12139

File Section File VM
chip-all-clusters-app.elf .flash.text 220 220
chip-all-clusters-app.elf .flash.rodata 64 64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,489
.debug_info,0,348
.flash.text,220,220
.debug_ranges,0,88
.debug_loc,0,68
.flash.rodata,64,64
.strtab,0,52
.debug_frame,0,20
.symtab,0,16
.riscv.attributes,0,3
[Unmapped],0,-284


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 1d12139

File Section File VM
chip-lock.elf text 200 200
chip-lock.elf rodata 56 60
chip-lock.elf device_handles 8 8
chip-shell.elf text 96 96
chip-shell.elf rodata 40 44
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,570
.debug_loc,0,376
text,200,200
.debug_line,0,154
.debug_ranges,0,152
rodata,60,56
.strtab,0,52
.debug_frame,0,44
.symtab,0,32
device_handles,8,8

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,436
.debug_loc,0,360
.debug_line,0,164
.debug_ranges,0,152
text,96,96
.strtab,0,52
rodata,44,40
.symtab,0,32


@bzbarsky-apple
Copy link
Contributor Author

@LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Please take a look?

@bzbarsky-apple bzbarsky-apple merged commit dbbe48d into project-chip:master Sep 21, 2021
@bzbarsky-apple bzbarsky-apple deleted the exchange-id-logging branch September 21, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants