-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clearer logging of exchange ids. #9861
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:exchange-id-logging
Sep 21, 2021
Merged
Add clearer logging of exchange ids. #9861
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:exchange-id-logging
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exchange ids are scoped to the initiator, so a bare exchange id does not uniquely identify he exchange. For now, just log with each id whether we are the initiator or the responder, which should at least help disambiguate that.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
tcarmelveilleux
September 21, 2021 17:22
pullapprove
bot
requested review from
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple and
yufengwangca
September 21, 2021 17:22
Size increase report for "gn_qpg-example-build" from 1d12139
Full report output
|
Size increase report for "esp32-example-build" from 1d12139
Full report output
|
Size increase report for "nrfconnect-example-build" from 1d12139
Full report output
|
andy31415
approved these changes
Sep 21, 2021
tcarmelveilleux
approved these changes
Sep 21, 2021
saurabhst
approved these changes
Sep 21, 2021
msandstedt
approved these changes
Sep 21, 2021
@LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Please take a look? |
jmartinez-silabs
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchange ids are scoped to the initiator, so a bare exchange id does
not uniquely identify he exchange. For now, just log with each id
whether we are the initiator or the responder, which should at least
help disambiguate that.
Problem
See above.
Change overview
See above.
Testing
No behavior changes, other than logging output.