-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename classes in transport layer #9814
Conversation
SecureSession => CryptoContext PeerConnectionState => SecureSession PeerConnections => SecureSessionTable SecureSessionMgr => SessionManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as automated rename change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Imho SecureSessionKeys
would be a better name than CryptoContext
as the latter sounds pretty generic, but anyway it's an improvement. Thanks for the cleanup!
@kghost - conflicts (large renames are likely to conflict in general :/ unfortunate) |
I would like to see @pan-apple or @bzbarsky-apple take a look at this before merge, given some semantic renames, but overall looks good. |
Thanks! |
c70c5d9
to
03372a3
Compare
Size increase report for "nrfconnect-example-build" from 0ade2d5
Full report output
|
Size increase report for "esp32-example-build" from 0ade2d5
Full report output
|
Problem
Class names in transport layer is not proper
Change overview
Rename classes in transport
SecureSession => CryptoContext
PeerConnectionState => SecureSession
PeerConnections => SecureSessionTable
SecureSessionMgr => SessionManager
This PR is automatically generated using following commands:
Note: git-sed is in git-extras package of debian/ubuntu
Testing
Verified using unit-tests