-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for open pairing window on chip-tool #9806
Merged
woody-apple
merged 1 commit into
project-chip:master
from
cecille:chip_tool_open_pairing_window
Sep 20, 2021
Merged
Fixes for open pairing window on chip-tool #9806
woody-apple
merged 1 commit into
project-chip:master
from
cecille:chip_tool_open_pairing_window
Sep 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the previous version would generate a random nodeid and then attempt to open the pairing window on that. Issue project-chip#9550 indicates a general failure to send commands after provisioning, but it actually looks like the open pairing window command is the only one affected. Issue speculates that PersistDevice was not called, but confirmed that PersistDevice IS called. However, the data for a randomly generated node id would not be present so the symptoms may match. We also need to connect to the device before sending the open pairing windo command as it is a standard cluster command. Added calls to connect to the device before opening the pairing window. Test: ./chip-tool pairing onnetwork 0 20202021 3840 fc00::a 5540 ./chip-tool onoff on 1 ./chip-tool pairing open-commissioning-window 0 5000 1 3840 ./chip-tool pairing onnetwork 0 20202021 3840 fc00::a 5540 ./chip-tool onoff on 1
Ideally we'd just ask for an operational cert for the commissionnee
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
turon
September 17, 2021 19:16
pullapprove
bot
requested review from
vivien-apple,
woody-apple and
yufengwangca
September 17, 2021 19:16
woody-apple
approved these changes
Sep 17, 2021
andy31415
approved these changes
Sep 20, 2021
saurabhst
approved these changes
Sep 20, 2021
I believe this is already in TE6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It looks like the previous version would generate a random nodeid
and then attempt to open the pairing window on that. Issue #9550
indicates a general failure to send commands after provisioning,
but it actually looks like the open pairing window command is the
only one affected. Issue speculates that PersistDevice was not
called, but I confirmed that PersistDevice IS called. However,
the data for a randomly generated node id would not be present
so the symptoms may match.
We also need to connect to the device before sending the open
pairing window command as it is a standard cluster command.
Change overview
Don't generate random id for open pairing window call.
Added calls to connect to the device before opening the pairing window.
Testing
Tested command sequence on chip-tool using lightning app on linux
./chip-tool pairing onnetwork 0 20202021 3840 fc00::a 5540
./chip-tool onoff on 1
./chip-tool pairing open-commissioning-window 0 5000 1 3840
./chip-tool pairing onnetwork 0 20202021 3840 fc00::a 5540
./chip-tool onoff on 1