Add configuration option for more verbose VerifyOrDie messages. #9800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of VerifyOrDie with no messages, and when they fail it's hard to tell what went wrong. This change adds a configuration option to automatically generate a verbose message string for VerifyOrDie if one is not provided. The option is off by default but enabled for Darwin and Linux. Log from a failing unit test without this change: [1631900831920] [73638:57013508] CHIP: [EM] Piggybacking Ack for MessageCounter:0000000D with msg ../../third_party/pigweed/repo/targets/host/run_test: line 18: 73638 Abort trap: 6 "$@" INF Test 1/1: [FAIL] TestReliableMessageProtocol Log from the same failure with this change: [1631900926163] [79197:57035322] CHIP: [EM] Piggybacking Ack for MessageCounter:0000000D with msg [1631900926163] [79197:57035322] CHIP: [SPT] VerifyOrDie failure at ../../src/messaging/ReliableMessageMgr.cpp:262: rc != nullptr && !rc->IsOccupied() ../../third_party/pigweed/repo/targets/host/run_test: line 18: 79197 Abort trap: 6 "$@" INF Test 1/1: [FAIL] TestReliableMessageProtocol
bzbarsky-apple
force-pushed
the
verbose-verify-or-die
branch
from
3dce9c7 to
e0dd2f7
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple and
woody-apple
saurabhst
approved these changes
Sep 17, 2021
woody-apple
approved these changes
Sep 17, 2021
andy31415
approved these changes
Sep 17, 2021
andy31415
added
review - pending
technical review - DONE
and removed
review - approved
labels
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
…ect-chip#9800) We have a lot of VerifyOrDie with no messages, and when they fail it's hard to tell what went wrong. This change adds a configuration option to automatically generate a verbose message string for VerifyOrDie if one is not provided. The option is off by default but enabled for Darwin and Linux. Log from a failing unit test without this change: [1631900831920] [73638:57013508] CHIP: [EM] Piggybacking Ack for MessageCounter:0000000D with msg ../../third_party/pigweed/repo/targets/host/run_test: line 18: 73638 Abort trap: 6 "$@" INF Test 1/1: [FAIL] TestReliableMessageProtocol Log from the same failure with this change: [1631900926163] [79197:57035322] CHIP: [EM] Piggybacking Ack for MessageCounter:0000000D with msg [1631900926163] [79197:57035322] CHIP: [SPT] VerifyOrDie failure at ../../src/messaging/ReliableMessageMgr.cpp:262: rc != nullptr && !rc->IsOccupied() ../../third_party/pigweed/repo/targets/host/run_test: line 18: 79197 Abort trap: 6 "$@" INF Test 1/1: [FAIL] TestReliableMessageProtocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of VerifyOrDie with no messages, and when they fail it's
hard to tell what went wrong. This change adds a configuration option
to automatically generate a verbose message string for VerifyOrDie if
one is not provided. The option is off by default but enabled for
Darwin and Linux.
Log from a failing unit test without this change:
Log from the same failure with this change:
Problem
See above
Change overview
See above
Testing
Manually ran a unit test that fails in VerifyOrDie on Mac; see logs above.