Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group] Add group ID retrieval #9765

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Conversation

jepenven-silabs
Copy link
Contributor

Problem

While Node ID can be retrieved from the message header, the code for the Group ID retrieval was missing

Change overview

Added code to handle the Group ID in the message header

Testing

How was this tested? (at least one bullet point required)

  • I If unit tests were added, how do they cover this issue?
    Same coverage as for the Node ID inside the TestMessagesHeader unit test with Set/Clear/Encode/Decode

@todo
Copy link

todo bot commented Sep 16, 2021

Consider making this a class and the various utility methods static

// TODO: Consider making this a class and the various utility methods static
// methods.
using GroupId = uint16_t;
constexpr GroupId kUndefinedGroupId = 0ULL;
constexpr GroupId kMaxOperationalGroupId = 0xFFFFULL;
constexpr bool IsOperationalGroupId(GroupId aGroupId)
{
return (aGroupId != kUndefinedGroupId) && (aGroupId <= kMaxOperationalGroupId);


This comment was generated by todo based on a TODO comment in 8832118 in #9765. cc @jepenven-silabs.

@jepenven-silabs jepenven-silabs force-pushed the group_id branch 2 times, most recently from 5595e34 to 03d1f60 Compare September 17, 2021 14:44
src/app/util/basic-types.h Outdated Show resolved Hide resolved
src/lib/core/GroupId.h Outdated Show resolved Hide resolved
@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 29a126f

File Section File VM
chip-qpg6100-lighting-example.out .text 104 104
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,30488
.debug_line,0,1954
.debug_loc,0,1456
.debug_str,0,891
.debug_abbrev,0,475
.debug_ranges,0,400
.text,104,104
[Unmapped],0,-104

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@andy31415 andy31415 merged commit cabc2f8 into project-chip:master Sep 21, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from 29a126f

File Section File VM
chip-all-clusters-app.elf .flash.text 120 120
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,43070
.debug_line,0,1826
.debug_str,0,916
.debug_abbrev,0,476
.flash.text,120,120
.debug_ranges,0,96
.riscv.attributes,0,-2
.debug_loc,0,-42
[Unmapped],0,-120


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 29a126f

File Section File VM
chip-lock.elf text 120 120
chip-lock.elf device_handles -8 -8
chip-shell.elf text 116 116
chip-shell.elf device_handles 12 12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,29340
.debug_line,0,1864
.debug_loc,0,1289
.debug_str,0,891
.debug_abbrev,0,476
.debug_ranges,0,400
text,120,120
.debug_frame,0,4
device_handles,-8,-8

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,10582
.debug_loc,0,1385
.debug_line,0,896
.debug_str,0,891
.debug_ranges,0,400
text,116,116
.debug_abbrev,0,82
device_handles,12,12
.debug_frame,0,4


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants