-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Add group ID retrieval #9765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider making this a class and the various utility methods staticconnectedhomeip/src/lib/core/GroupId.h Lines 24 to 34 in 8832118
This comment was generated by todo based on a
|
jepenven-silabs
force-pushed
the
group_id
branch
2 times, most recently
from
September 17, 2021 14:44
5595e34
to
03d1f60
Compare
jepenven-silabs
force-pushed
the
group_id
branch
from
September 17, 2021 15:16
03d1f60
to
3c3690a
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
September 17, 2021 16:32
pullapprove
bot
requested review from
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
turon,
vivien-apple,
woody-apple and
yufengwangca
September 17, 2021 16:32
msandstedt
reviewed
Sep 17, 2021
woody-apple
approved these changes
Sep 17, 2021
andy31415
approved these changes
Sep 20, 2021
jepenven-silabs
force-pushed
the
group_id
branch
from
September 21, 2021 12:49
be1e29c
to
e188bb3
Compare
msandstedt
approved these changes
Sep 21, 2021
Size increase report for "gn_qpg-example-build" from 29a126f
Full report output
|
Size increase report for "esp32-example-build" from 29a126f
Full report output
|
Size increase report for "nrfconnect-example-build" from 29a126f
Full report output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While Node ID can be retrieved from the message header, the code for the Group ID retrieval was missing
Change overview
Added code to handle the Group ID in the message header
Testing
How was this tested? (at least one bullet point required)
Same coverage as for the Node ID inside the TestMessagesHeader unit test with Set/Clear/Encode/Decode