Unify Android build logic #9762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
android
documentation
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
turon
pullapprove
bot
requested review from
vivien-apple,
woody-apple and
yunhanw-google
saurabhst
approved these changes
Sep 16, 2021
|
Oops, didn't mean to re-request from Saurabh. |
woody-apple
approved these changes
Sep 17, 2021
andy31415
approved these changes
Sep 20, 2021
|
@austinh0 - the build_examples.py build script has unit tests. You will need to add/modify the file scripts/build/expected_all_platform_commands.txt (remeber to use the placeholders {out} and {root} and such. |
austinh0
force-pushed
the
android-build
branch
from
d3cb794 to
d79e3a7
Compare
austinh0
force-pushed
the
android-build
branch
from
d79e3a7 to
3efa284
Compare
|
Updated the expected commands and the tests pass. |
austinh0
force-pushed
the
android-build
branch
from
3efa284 to
a88be7a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
scripts/build/builders/android.pyis used in the CI to build the Android CHIPTool, butscripts/examples/android_app.shdoes the same thing and is used by devs locallyChange overview
android_app.shis renamedandroid_app_ide.shand only supports the IDE build path now.android_app.py./gradlew build->./gradlew assembleDebug.buildcompiles debug and release APKs, which seems unnecessary and is slow.Testing
android.pyused by Android CI