Print mrp and tcp values in python discover. #9755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
approved these changes
Sep 16, 2021
woody-apple
approved these changes
Sep 16, 2021
LuDuda
approved these changes
Sep 16, 2021
|
Why do we have tabs in logs? |
|
tabls just line them up nicely. This function is literally used for nothing but printing as part of the python controller output. |
pullapprove
bot
requested review from
chrisdecenzo,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
msandstedt and
saurabhst
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MRP and T flags are not printed in the discovery summary in the python controller
Change overview
Adds the prints
Testing
Tested against lighting app with and without the flags set - both prints look fine.