-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _I subtype to operational discovery. #9754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
shana-apple
September 16, 2021 13:50
pullapprove
bot
requested review from
tcarmelveilleux,
vivien-apple and
woody-apple
September 16, 2021 13:50
woody-apple
approved these changes
Sep 16, 2021
jmartinez-silabs
approved these changes
Sep 17, 2021
Size increase report for "gn_qpg-example-build" from 655b759
Full report output
|
Size increase report for "nrfconnect-example-build" from 655b759
Full report output
|
Size increase report for "esp32-example-build" from 655b759
Full report output
|
tcarmelveilleux
approved these changes
Sep 17, 2021
msandstedt
approved these changes
Sep 17, 2021
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
* Add _I subtype to operational discovery. * Fix tv app for new discovery filter type. * Use BytesToHex rather than PRIX64. * Doxygen, add comment from review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spec updates added a _I subtype to operational discovery advertisements that is meant to be used to search for devices in a particular fabric. Original code was written before this was added, so this was not handled in the SDK.
Change overview
Add _I subtype to the discovery filter and service naming code, adds _I to operational network advertisements in minimal and platform. Also changes names in minimal mdns advertising to match dns-sd spec. Adds tests for service naming and advertisers
Testing