Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _I subtype to operational discovery. #9754

Merged
merged 5 commits into from
Sep 17, 2021

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Sep 16, 2021

Problem

Spec updates added a _I subtype to operational discovery advertisements that is meant to be used to search for devices in a particular fabric. Original code was written before this was added, so this was not handled in the SDK.

Change overview

Add _I subtype to the discovery filter and service naming code, adds _I to operational network advertisements in minimal and platform. Also changes names in minimal mdns advertising to match dns-sd spec. Adds tests for service naming and advertisers

Testing

  • service naming unit tests in TestServiceNaming
  • minimal adverts tested in TestAdvertiser
  • platform adverts tested in TestPlatform
  • tested manually on linux lighting app using avahi

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 655b759

File Section File VM
chip-qpg6100-lighting-example.out .text 932 932
chip-qpg6100-lighting-example.out .bss 0 16
chip-qpg6100-lighting-example.out .data 4 4
chip-qpg6100-lighting-example.out .heap 0 -16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,61219
.debug_line,0,3585
.debug_str,0,3389
.debug_loc,0,3030
.debug_abbrev,0,2561
.strtab,0,1336
.text,932,932
.symtab,0,880
.debug_ranges,0,392
.debug_frame,0,360
.debug_aranges,0,112
.bss,16,0
.data,4,4
.heap,-16,0
[ELF Program Headers],0,-32
[Unmapped],0,-900

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 655b759

File Section File VM
chip-shell.elf text 344 344
chip-shell.elf rodata 16 16
chip-shell.elf device_handles 8 8
chip-lock.elf text 720 720
chip-lock.elf rodata 88 88
chip-lock.elf bss 0 32
chip-lock.elf init_array 4 4
chip-lock.elf device_handles -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,2307
.debug_loc,0,773
text,344,344
.debug_line,0,327
.debug_str,0,143
.debug_abbrev,0,110
.debug_frame,0,100
.symtab,0,80
.strtab,0,79
.debug_ranges,0,40
rodata,16,16
.debug_aranges,0,8
device_handles,8,8
.shstrtab,0,1

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,80522
.debug_line,0,7387
.debug_str,0,5262
.debug_abbrev,0,4759
.debug_loc,0,3162
.strtab,0,1401
.symtab,0,896
text,720,720
.debug_ranges,0,416
.debug_frame,0,404
.debug_aranges,0,144
rodata,88,88
bss,32,0
init_array,4,4
.shstrtab,0,3
device_handles,-4,-4


@github-actions
Copy link

Size increase report for "esp32-example-build" from 655b759

File Section File VM
chip-all-clusters-app.elf .flash.text 968 968
chip-all-clusters-app.elf .dram0.bss 0 184
chip-all-clusters-app.elf .flash.rodata 104 104
chip-all-clusters-app.elf .dram0.heap_start 0 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,52002
.debug_line,0,4356
.debug_str,0,3942
.debug_loc,0,2971
.debug_abbrev,0,1451
.strtab,0,1375
.flash.text,968,968
.debug_ranges,0,584
.debug_frame,0,368
.symtab,0,336
.dram0.bss,184,0
.debug_aranges,0,120
.flash.rodata,104,104
.dram0.data,0,8
.shstrtab,0,1
.riscv.attributes,0,-2
.dram0.heap_start,-8,0
[Unmapped],0,-1080


@cecille cecille merged commit a0bb79f into project-chip:master Sep 17, 2021
@cecille cecille deleted the i_subtype branch September 17, 2021 17:19
mleisner pushed a commit to mleisner/connectedhomeip that referenced this pull request Sep 20, 2021
* Add _I subtype to operational discovery.

* Fix tv app for new discovery filter type.

* Use BytesToHex rather than PRIX64.

* Doxygen, add comment from review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants