Fix ToT failure on avahi #9744
Merged
Fix ToT failure on avahi #9744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
approved these changes
Sep 16, 2021
tcarmelveilleux
approved these changes
Sep 16, 2021
|
/rebase |
woody-apple
force-pushed
the
avahi_fix
branch
from
7ebe77f to
7cdbcf9
Compare
|
@saurabhst @LuDuda @msandstedt @jepenven-silabs @chrisdecenzo @jmartinez-silabs ? This seems to be stuck on restyler (??? ... @woody-apple is there a way to kick it) however if we get enough checkmarks I can admin-merge it. Waiting >1day over a one line fix seems harsh |
msandstedt
approved these changes
Sep 16, 2021
|
@andy31415 Restyled issues can be filed here: https://github.com/restyled-io/restyler/issues I'll label this restyled-ignore, and merge. |
|
Filed: restyled-io/restyler#156 |
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current ToT code calls PublishService twice in a row during startup - once during a call to open the pairing window, one during the general server startup. There's also a Stop called between them. On ToT this was failing. Root caused to Stop not depopulating the list of services, so we were attempting to update a service that had already been stopped.
Fixes #9695
Change overview
Add a clear to the Stop call in the avahi mdnsImpl
Testing
No unit tests for avahi impl - tested on linux lighting-app, can see error no longer prints, can find on avahi-discover.