-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IM status response support and replace status report with status response for IM read/subscribe #9706
Add IM status response support and replace status report with status response for IM read/subscribe #9706
Conversation
8f3bc0e
to
83607f4
Compare
83607f4
to
3a96af1
Compare
3a96af1
to
e135688
Compare
3b8aefa
to
6c8ebab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two general comments: is protocolCode actually 32-bit? I thought it was 16-bit. Second, since we're already touching all of them, can we replace all of the intXX_t types with and format strings with typedefs and constexprs?
And apologies if protocol code is 32-bit. If so, can I be pointed to the part of the spec where this is defined? All of the protocol code examples imply these are 16-bit.
Answered offline. Yes, ProtocolCode is 32bit now. Typedefes and constexprs for all of the places we currently have uint32_t and PRIx32 would be nice, but don't need to block this PR. Thanks. |
|
6c8ebab
to
2f78449
Compare
Problems: Interaction Model spec has introduced status reponse message and used it for IM Read/Subscribe. Currently IM read/subscribe code still use status report from secure channel, we need to update it with status reponse. Summary of Changes: -- Add status reponse message builder and parser and test -- Replace status report with status response message for IM read/subscribe
2f78449
to
7fb1793
Compare
Size increase report for "gn_qpg-example-build" from 8e86c9e
Full report output
|
Size increase report for "nrfconnect-example-build" from 8e86c9e
Full report output
|
Size increase report for "esp32-example-build" from 8e86c9e
Full report output
|
Problems: Interaction Model spec has introduced status reponse message and used it for IM Read/Subscribe. Currently IM read/subscribe code still use status report from secure channel, we need to update it with status reponse. Summary of Changes: -- Add status reponse message builder and parser and test -- Replace status report with status response message for IM read/subscribe
Problem
Interaction Model spec has introduced status response message and used it
for IM Read/Subscribe. Currently IM read/subscribe code still use status
report from secure channel, we need to update it with status response.
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Encoding-Specification.adoc#encoding-StatusResponseMessage
#9700
Change overview
-- Add status response message builder and parser and test
-- Replace status report with status response message for IM
read/subscribe
Testing
How was this tested? (at least one bullet point required)
-- Add Status response unit test
-- update in IM read/subscribe has been covered by existing test.