-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestUDP: use ephemeral port #9692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
September 14, 2021 14:35
msandstedt
approved these changes
Sep 14, 2021
mlepage-google
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #6947 was happening regularly for me, but with this change, it hasn't happened after half a dozen attempts.
Size increase report for "nrfconnect-example-build" from 29e6bcd
Full report output
|
andy31415
approved these changes
Sep 14, 2021
Size increase report for "esp32-example-build" from 29e6bcd
Full report output
|
mspang
approved these changes
Sep 14, 2021
yunhanw-google
approved these changes
Sep 14, 2021
woody-apple
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix TestUDP failure. The problem is triggered when multiple TestUDP (gcc/clang/mbedtls variant) is running concurrently, then their UDP port may conflict.
Change overview
In TestUDP, use ephemeral port instead of CHIP_PORT (5540)
Testing
Verified by unit-tests