-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable act tool for running CI jobs locally #9648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upload GH action requires a server to store objects, this a well-known limitation for the usage of act tool. This change makes disable the Upload GH action when act tool is performing locally. Signed-off-by: Victor Morales <[email protected]>
This change upgrades some GH actions that were using an older version of upload-artifact GH action. Signed-off-by: Victor Morales <[email protected]>
This change adds a condition to disable the haya14busa/action-cond action of nrfconnect job during the execution of act tool. Signed-off-by: Victor Morales <[email protected]>
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
September 13, 2021 20:04
Size increase report for "esp32-example-build" from c23f6f4
Full report output
|
andy31415
approved these changes
Sep 14, 2021
woody-apple
approved these changes
Sep 14, 2021
This is awesome, thank you! |
jmartinez-silabs
approved these changes
Sep 16, 2021
pullapprove
bot
requested review from
Damian-Nordic,
hawk248 and
msandstedt
September 16, 2021 01:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
act tool allows to execute GitHub actions locally. Actions like upload-artifact and cache use third-party services configured defined through ACTIONS_RUNTIME_URL, ACTIONS_RUNTIME_TOKEN and ACTIONS_CACHE_URL environment variables, this dependency limits the execution of act tool.
Change overview
This change allows the execution of act tool locally for development and validation of GitHub jobs.
It also upgrade the upload-artifact GH action version to v2.
Testing
To run this locally it's necessary to install act and its dependencies described here. Once it's installed, CI jobs can be tested executing the following command: