Adding cmd line args to tv-casting-app for device type of commissioners to be discovered #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to be discovered
pullapprove
bot
requested review from
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
|
Please update the summary to not include the 'example text' |
andy31415
reviewed
Sep 9, 2021
chrisdecenzo
approved these changes
Sep 9, 2021
bzbarsky-apple
approved these changes
Sep 9, 2021
woody-apple
approved these changes
Sep 10, 2021
sharadb-amazon
force-pushed
the
tv-casting-app-dt
branch
from
121538c to
8e7a80e
Compare
andy31415
reviewed
Sep 10, 2021
jmartinez-silabs
approved these changes
Sep 13, 2021
…evice type, defaulting to 'all'
|
Updated the code. Waiting for andy31415@ to review/approve. :) |
andy31415
approved these changes
Sep 14, 2021
|
I have validated that the 2 device types added as an example match the spec received (not yet in official spec, but the list I received from the spec writers) |
Looks like all checks passed. Could you (or someone else who has permissions) please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The tv-casting-app could only discover a fixed, hard coded type of commissioner to request commissioning from.
Change overview
This change allows passing in a device type ("all" or a specific device type id) as a command line argument, so that the user can choose to request commissioning from a non-video player device (video player commissioner is still the default)
Testing
Tested against minimal-mdns to make sure the tv-casting-app is able to discover non-video player device type commissioners.