-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YAML] Generates write attribute methods for non writeable attributes #9554
Merged
woody-apple
merged 4 commits into
project-chip:master
from
vivien-apple:Tests_GeneratesWriteAttributeMethodsForNonWriteable2
Sep 16, 2021
Merged
[YAML] Generates write attribute methods for non writeable attributes #9554
woody-apple
merged 4 commits into
project-chip:master
from
vivien-apple:Tests_GeneratesWriteAttributeMethodsForNonWriteable2
Sep 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Tests_GeneratesWriteAttributeMethodsForNonWriteable2
branch
3 times, most recently
from
September 9, 2021 07:18
369758e
to
6968835
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
pan-apple
September 9, 2021 07:19
bzbarsky-apple
approved these changes
Sep 9, 2021
@vivien-apple The Linux compile failures seem unrelated to your changes... needs a rebase? |
Yes, needs to be rebased on top of #9560. |
/rebase |
woody-apple
force-pushed
the
Tests_GeneratesWriteAttributeMethodsForNonWriteable2
branch
from
September 9, 2021 22:01
6968835
to
4ec3a26
Compare
woody-apple
approved these changes
Sep 13, 2021
saurabhst
approved these changes
Sep 13, 2021
msandstedt
approved these changes
Sep 13, 2021
andy31415
approved these changes
Sep 15, 2021
@vivien-apple - conflicts |
…writeable attributes
…iteable attributes
…Revision/FeatureMap
vivien-apple
force-pushed
the
Tests_GeneratesWriteAttributeMethodsForNonWriteable2
branch
from
September 15, 2021 22:37
4ec3a26
to
e40a73c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some tests are trying to write to attributes that are not writeable.
This PR expose a test interface wrapping the normal cluster interface but with methods for writing to such attributes.
For example
OnOffCluster
is the base class forOnOffClusterTest
:All those methods should results into the controller returning an error when they are received. They are not useful for regular operations, but it is useful to check that the controllee implements those attributes properly.
Change overview
Testing
I have enabled more yaml tests.